Plexon2: Fix conversion between C++ tm structure and python datetime #1372
Conversation
|
@h-mayorquin, I know you read over and help with the |
alejoe91
changed the title
h-mayorquin
left a comment
h-mayorquin
left a comment
There was a problem hiding this comment.
I think that being off by a second with the leap second is fine. Glad that @alejoe91 had the time to check it.
|
@h-mayorquin, my point for leap second is that based on my reading Python datetime will not accept the leap second value tm can return 60 or 61 to count as leap seconds, but datatime second only accepts 0..59. So in the case that someone records on a leap second then this IO could fail to annotate the date. |
|
What I mean is to just substract 1 and make it 60 in that case. The other solution would be to propagate all the way up to year in th worse case scenario which is indded difficult as I think you were pointing out. But also, having the current code just failn and then have someone coming here to tell us so we can device a better solutio nwith an example in our hands seems like a good option : ) |
4 participants
Fixes #1371.
As explained in the issue the structures are indexed different so we need to +1 to correctly index. Add comment to explain this with links.